Fix AF+ item names for wallpaper/carpet #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuyler36
requested changes
May 9, 2021
Cuyler36
reviewed
May 9, 2021
| @@ -147,7 +147,7 @@ public static ItemType GetItemType(ushort id, SaveType saveType) | |||
| return ItemType.Item; | |||
| else if (id >= 0x2C00 && id <= 0x2C5F) | |||
| return ItemType.RaffleTicket; | |||
| else if ((id >= 0x2600 && id <= 0x2642) || (id >= 0x2700 && id <= 0x2742)) | |||
| else if ((id >= 0x2600 && id <= 0x263F) || (id >= 0x2700 && id <= 0x273F)) | |||
There was a problem hiding this comment.
DnM/Dongwu Senlin need their own case so that wallpapers and carpets added in later are categorized correctly.
|
is this solved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Discord -- the Japan-only items were not in the AF+ item list. Additionally, some items that were not in AF+ (Mario carpet/wallpaper, boxing ring carpet/wallpaper, harvest carpet/wallpaper) were in the AF+ item list. Finally, correct names of old board floor / worn-out mud wall in AFe+ list.
While putting this together I learned that, at least in AF+, hex IDs past the end of the valid range can be displayed as wallpaper/carpet (though the items themselves are glitchy when dropped on the ground and in the inventory), and appear to be carpet or wallpaper either from shops or potentially even unused. Possible investigation for a follow-on PR.